Generate typedef node from the element.

Generate typedef node from the element.

BUG=
R=sigurdm@google.com

Committed: https://code.google.com/p/dart/source/detail?r=42238

[Johnni Winther, 2014-12-05 13:55:02]

johnniwinther@google.com changed reviewers:
+ sigurdm@google.com

[sigurdm, 2014-12-08 13:02:30]

lgtm

https://codereview.chromium.org/764023005/diff/1/pkg/compiler/lib/src/dart_ba...
File pkg/compiler/lib/src/dart_backend/backend.dart (right):

https://codereview.chromium.org/764023005/diff/1/pkg/compiler/lib/src/dart_ba...
pkg/compiler/lib/src/dart_backend/backend.dart:19: ElementAst.internal(this.ast,
this.treeElements);
Maybe we can find a better name than internal if this is the preferred
constructor now?

https://codereview.chromium.org/764023005/diff/1/pkg/compiler/lib/src/dart_ba...
File pkg/compiler/lib/src/dart_backend/backend_ast_emitter.dart (right):

https://codereview.chromium.org/764023005/diff/1/pkg/compiler/lib/src/dart_ba...
pkg/compiler/lib/src/dart_backend/backend_ast_emitter.dart:598: visitExpression(
Is there trailing whitespace here? It looks like that in the review tool.

https://codereview.chromium.org/764023005/diff/1/pkg/compiler/lib/src/dart_ba...
pkg/compiler/lib/src/dart_backend/backend_ast_emitter.dart:755: class
TypeGenerator {
All the methods are static. Do we need the class at all?

[Johnni Winther, 2014-12-10 08:47:54]

https://codereview.chromium.org/764023005/diff/1/pkg/compiler/lib/src/dart_ba...
File pkg/compiler/lib/src/dart_backend/backend.dart (right):

https://codereview.chromium.org/764023005/diff/1/pkg/compiler/lib/src/dart_ba...
pkg/compiler/lib/src/dart_backend/backend.dart:19: ElementAst.internal(this.ast,
this.treeElements);
On 2014/12/08 13:02:29, sigurdm wrote:
> Maybe we can find a better name than internal if this is the preferred
> constructor now?

Remove the no-name constructor and made this the no-name constructor instead.

https://codereview.chromium.org/764023005/diff/1/pkg/compiler/lib/src/dart_ba...
File pkg/compiler/lib/src/dart_backend/backend_ast_emitter.dart (right):

https://codereview.chromium.org/764023005/diff/1/pkg/compiler/lib/src/dart_ba...
pkg/compiler/lib/src/dart_backend/backend_ast_emitter.dart:598: visitExpression(
On 2014/12/08 13:02:30, sigurdm wrote:
> Is there trailing whitespace here? It looks like that in the review tool.

No. It's clean.

https://codereview.chromium.org/764023005/diff/1/pkg/compiler/lib/src/dart_ba...
pkg/compiler/lib/src/dart_backend/backend_ast_emitter.dart:755: class
TypeGenerator {
On 2014/12/08 13:02:29, sigurdm wrote:
> All the methods are static. Do we need the class at all?

We don't need it but I wanted to group all methods for creating types so that
dependency (from backend->frontend ast) clearly shows its use. The functionality
might become part of the ASTEmitter, once we don't convert to frontend ast.

[Johnni Winther, 2014-12-10 09:18:12]

Committed patchset #4 (id:60001) manually as 42238 (presubmit successful).