Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 763993002: Extract BuilderContext from ASTEmitter (Closed)

Created:
6 years ago by Johnni Winther
Modified:
6 years ago
Reviewers:
sigurdm
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Extract BuilderContext from ASTEmitter BUG= R=sigurdm@google.com Committed: https://code.google.com/p/dart/source/detail?r=42034

Patch Set 1 #

Patch Set 2 : Update docgen. #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+595 lines, -361 lines) Patch
M pkg/compiler/lib/src/constants/expressions.dart View 10 chunks +44 lines, -27 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/backend_ast_emitter.dart View 1 2 22 chunks +439 lines, -322 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart View 1 2 29 chunks +100 lines, -0 lines 0 comments Download
M pkg/docgen/lib/src/models/model_helpers.dart View 1 1 chunk +12 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Johnni Winther
6 years ago (2014-11-28 09:31:21 UTC) #2
sigurdm
lgtm
6 years ago (2014-11-28 15:18:55 UTC) #3
Johnni Winther
6 years ago (2014-12-01 10:04:43 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 42034 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698