Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 76383002: Update InternetAddress (Closed)

Created:
7 years, 1 month ago by Søren Gjesse
Modified:
7 years, 1 month ago
Reviewers:
Anders Johnsen
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Update InternetAddress Add InternetAddress constructor for numeric addresses. An InternetAddress can now be constructed without using DNS resolving. Add hash code calculated from the bytes of the address. Add equality operator comparing the bytes of the address. Added check for multicast addresses. R=ajohnsen@google.com Committed: https://code.google.com/p/dart/source/detail?r=30449

Patch Set 1 #

Patch Set 2 : New upload #

Patch Set 3 : Update Windows and Mac OS code #

Total comments: 4

Patch Set 4 : Addressed review commetns #

Unified diffs Side-by-side diffs Delta from patch set Stats (+218 lines, -5 lines) Patch
M runtime/bin/io_natives.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/socket.h View 2 chunks +10 lines, -0 lines 0 comments Download
M runtime/bin/socket.cc View 1 chunk +26 lines, -5 lines 0 comments Download
M runtime/bin/socket_android.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M runtime/bin/socket_linux.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M runtime/bin/socket_macos.cc View 1 2 1 chunk +12 lines, -0 lines 0 comments Download
M runtime/bin/socket_patch.dart View 1 2 3 3 chunks +44 lines, -0 lines 0 comments Download
M runtime/bin/socket_win.cc View 1 2 1 chunk +14 lines, -0 lines 0 comments Download
M sdk/lib/io/socket.dart View 1 chunk +15 lines, -0 lines 0 comments Download
M tests/standalone/io/internet_address_test.dart View 2 chunks +72 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Søren Gjesse
7 years, 1 month ago (2013-11-20 09:43:04 UTC) #1
Anders Johnsen
LGTM! https://codereview.chromium.org/76383002/diff/50001/runtime/bin/socket_patch.dart File runtime/bin/socket_patch.dart (right): https://codereview.chromium.org/76383002/diff/50001/runtime/bin/socket_patch.dart#newcode118 runtime/bin/socket_patch.dart:118: return _sockaddr_storage[_IPV6_ADDR_OFFSET] == 0xFF; Check next byte for ...
7 years, 1 month ago (2013-11-20 09:51:50 UTC) #2
Søren Gjesse
https://codereview.chromium.org/76383002/diff/50001/runtime/bin/socket_patch.dart File runtime/bin/socket_patch.dart (right): https://codereview.chromium.org/76383002/diff/50001/runtime/bin/socket_patch.dart#newcode118 runtime/bin/socket_patch.dart:118: return _sockaddr_storage[_IPV6_ADDR_OFFSET] == 0xFF; On 2013/11/20 09:51:51, Anders Johnsen ...
7 years, 1 month ago (2013-11-20 10:00:28 UTC) #3
Søren Gjesse
7 years, 1 month ago (2013-11-20 10:01:35 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 manually as r30449 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698