Fix implementation of the Iterable interface for typed data lists.

Fix implementation of the Iterable interface for typed data lists.

Return an Iterable with the correct type arguments (instead of <dynamic>)
when calling Iterable methods.

R=lrn@google.com

Committed: https://code.google.com/p/dart/source/detail?r=42066

[Florian Schneider, 2014-12-02 09:35:25]

fschneider@google.com changed reviewers:
+ iposva@google.com, lrn@google.com

[Lasse Reichstein Nielsen, 2014-12-02 12:02:54]

LGTM, but if it can be improved to use ListBase/ListMixin instead, it would be
even better!

https://codereview.chromium.org/763443005/diff/1/runtime/lib/typed_data.dart
File runtime/lib/typed_data.dart (right):

https://codereview.chromium.org/763443005/diff/1/runtime/lib/typed_data.dart#...
runtime/lib/typed_data.dart:531: Iterable<double> where(bool f(int element)) =>
new WhereIterable<double>(this, f);
Long line (repeated below).

https://codereview.chromium.org/763443005/diff/1/runtime/lib/typed_data.dart#...
runtime/lib/typed_data.dart:564: Iterable<Float32x4> skip(int n) => new
SubListIterable<Float32x4>(this, n, null);
Long line.

https://codereview.chromium.org/763443005/diff/1/runtime/lib/typed_data.dart#...
runtime/lib/typed_data.dart:829: class _Int8Array extends _TypedList with
_IntListMixin implements Int8List {
Would it work to do:
  extends _TypedList with ListBase<int> implements Int8List
?
Or will that override some functions you don't want overridden?

Maybe
  extends ListBase<int> with _TypedList implements Int8List
(and remove all methods in TypedList that uses IterableMixinWorkaround)

[Florian Schneider, 2014-12-02 12:17:26]

https://codereview.chromium.org/763443005/diff/1/runtime/lib/typed_data.dart
File runtime/lib/typed_data.dart (right):

https://codereview.chromium.org/763443005/diff/1/runtime/lib/typed_data.dart#...
runtime/lib/typed_data.dart:531: Iterable<double> where(bool f(int element)) =>
new WhereIterable<double>(this, f);
On 2014/12/02 12:02:54, Lasse Reichstein Nielsen wrote:
> Long line (repeated below).

Done.

https://codereview.chromium.org/763443005/diff/1/runtime/lib/typed_data.dart#...
runtime/lib/typed_data.dart:564: Iterable<Float32x4> skip(int n) => new
SubListIterable<Float32x4>(this, n, null);
On 2014/12/02 12:02:54, Lasse Reichstein Nielsen wrote:
> Long line.

Done.

https://codereview.chromium.org/763443005/diff/1/runtime/lib/typed_data.dart#...
runtime/lib/typed_data.dart:829: class _Int8Array extends _TypedList with
_IntListMixin implements Int8List {
On 2014/12/02 12:02:54, Lasse Reichstein Nielsen wrote:
> Would it work to do:
>   extends _TypedList with ListBase<int> implements Int8List
> ?
> Or will that override some functions you don't want overridden?
> 
> Maybe
>   extends ListBase<int> with _TypedList implements Int8List
> (and remove all methods in TypedList that uses IterableMixinWorkaround)

In principle it would work. The down-side would be that every instance of typed
list would now have the type argument stored since the super class _TypedList
with _ListMixin<int> would have type arguments

With this approach (duplicating parts of ListMixin) we can get away without
actually storing type arguments in each object - saving one word per object.

[Florian Schneider, 2014-12-02 13:25:40]

Committed patchset #2 (id:20001) manually as r42066 (presubmit successful).