Issue 76243002: Don't supply host names for the fixed internet addresses

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 76243002: Don't supply host names for the fixed internet addresses (Closed)

Created:
7 years, 1 month ago by Søren Gjesse

Modified:
7 years, 1 month ago

Reviewers:
Anders Johnsen

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Don't supply host names for the fixed internet addresses The hard-coded host names "localhost" and "localhost-ip6" where taken from the default Ubuntu hosts file. But other machines (e.g the default on Mac OS) might be configured different. To avoid actual lookup of "localhost" and "localhost-ip6" returning a different address than the provided fixed loopback addresses don't add an actual host name. R=ajohnsen@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=30403

Patch Set 1 #

Patch Set 2 : Updated after offline discussion #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -14 lines)			Patch
M	runtime/bin/socket_patch.dart	View	1	4 chunks	+7 lines, -5 lines	0 comments	Download
M	sdk/lib/io/socket.dart	View	1	2 chunks	+6 lines, -7 lines	0 comments	Download
M	tests/standalone/io/internet_address_test.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

7 years, 1 month ago (2013-11-19 12:17:49 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r30403 (presubmit successful).

Expand Messages | Collapse Messages