Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 76233003: Add explicit cast to avoid bug in analyzer. (Closed)

Created:
7 years, 1 month ago by Lasse Reichstein Nielsen
Modified:
7 years, 1 month ago
Reviewers:
floitsch
CC:
reviews_dartlang.org, Brian Wilkerson
Visibility:
Public.

Description

Add explicit cast to avoid bug in analyzer. Committed: https://code.google.com/p/dart/source/detail?r=30405

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M pkg/collection_helpers/lib/typed_buffers.dart View 1 chunk +3 lines, -1 line 1 comment Download

Messages

Total messages: 3 (0 generated)
Lasse Reichstein Nielsen
TBR
7 years, 1 month ago (2013-11-19 12:22:34 UTC) #1
Lasse Reichstein Nielsen
Committed patchset #1 manually as r30405 (presubmit successful).
7 years, 1 month ago (2013-11-19 12:22:55 UTC) #2
floitsch
7 years, 1 month ago (2013-11-19 12:28:36 UTC) #3
Message was sent while issue was closed.
LGTM.

https://codereview.chromium.org/76233003/diff/1/pkg/collection_helpers/lib/ty...
File pkg/collection_helpers/lib/typed_buffers.dart (right):

https://codereview.chromium.org/76233003/diff/1/pkg/collection_helpers/lib/ty...
pkg/collection_helpers/lib/typed_buffers.dart:120: // Remove this cast when
15156 is fixed.
TODO(15156): Remove this cast.

Powered by Google App Engine
This is Rietveld 408576698