Issue 761483002: dart2js: don't pass the supername to visitFields.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 761483002: dart2js: don't pass the supername to visitFields. (Closed)

Created:
6 years ago by floitsch

Modified:
6 years ago

Reviewers:
sigurdm

CC:
reviews_dartlang.org, karlklose

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

dart2js: don't pass the supername to visitFields. R=sigurdm@google.com Committed: https://code.google.com/p/dart/source/detail?r=42247

Patch Set 1 #

Total comments: 1

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -21 lines)			Patch
M	pkg/compiler/lib/src/js_backend/native_emitter.dart	View	2 chunks	+12 lines, -11 lines	1 comment	Download
M	pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart	View	4 chunks	+3 lines, -9 lines	0 comments	Download
M	pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

floitsch

https://codereview.chromium.org/761483002/diff/1/pkg/compiler/lib/src/js_backend/native_emitter.dart File pkg/compiler/lib/src/js_backend/native_emitter.dart (right): https://codereview.chromium.org/761483002/diff/1/pkg/compiler/lib/src/js_backend/native_emitter.dart#newcode306 pkg/compiler/lib/src/js_backend/native_emitter.dart:306: builder.superName = superName; Line 306 is new. The rest ...

6 years ago (2014-11-25 15:17:13 UTC) #2

floitsch

6 years ago (2014-12-10 16:09:29 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 42247 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages