Incremental compilation of constants.

Incremental compilation of constants.

R=floitsch@google.com, johnniwinther@google.com

Committed: https://code.google.com/p/dart/source/detail?r=42283

[ahe, 2014-12-01 09:22:17]

ahe@google.com changed reviewers:
+ johnniwinther@google.com

[ahe, 2014-12-01 09:22:17]

Florian, FYI, I've made changes to the emitter.

[floitsch, 2014-12-01 14:13:17]

floitsch@google.com changed reviewers:
+ floitsch@google.com

[floitsch, 2014-12-01 14:13:18]

emitter changes LGTM.

[Johnni Winther, 2014-12-09 12:07:16]

lgtm

https://codereview.chromium.org/760383003/diff/1/dart/tests/try/web/increment...
File dart/tests/try/web/incremental_compilation_update_test.dart (right):

https://codereview.chromium.org/760383003/diff/1/dart/tests/try/web/increment...
dart/tests/try/web/incremental_compilation_update_test.dart:1399: ],
Add tests with dependent constants like const C(const B()) and constructed
constants of previously uninstantiated types.

[ahe, 2014-12-10 16:27:33]

Patchset #2 (id:20001) has been deleted

[ahe, 2014-12-11 10:09:01]

Thank you, Florian and Johnni!

@Johnni: PTAL at my conflict resolution.

https://codereview.chromium.org/760383003/diff/1/dart/tests/try/web/increment...
File dart/tests/try/web/incremental_compilation_update_test.dart (right):

https://codereview.chromium.org/760383003/diff/1/dart/tests/try/web/increment...
dart/tests/try/web/incremental_compilation_update_test.dart:1399: ],
On 2014/12/09 12:07:16, Johnni Winther wrote:
> Add tests with dependent constants like const C(const B()) and constructed
> constants of previously uninstantiated types.

Will do in follow up CL.

https://codereview.chromium.org/760383003/diff/40001/dart/pkg/dart2js_increme...
File dart/pkg/dart2js_incremental/lib/library_updater.dart (right):

https://codereview.chromium.org/760383003/diff/40001/dart/pkg/dart2js_increme...
dart/pkg/dart2js_incremental/lib/library_updater.dart:155: ? [] :
compiler.backend.constants.compiledConstants);
Conflict resolution.

https://codereview.chromium.org/760383003/diff/40001/dart/pkg/dart2js_increme...
dart/pkg/dart2js_incremental/lib/library_updater.dart:621:
_ensureNeedsComputed();
Conflict resolution.

https://codereview.chromium.org/760383003/diff/40001/dart/pkg/dart2js_increme...
dart/pkg/dart2js_incremental/lib/library_updater.dart:686:
_ensureNeedsComputed();
Conflict resolution.

https://codereview.chromium.org/760383003/diff/40001/dart/pkg/dart2js_increme...
dart/pkg/dart2js_incremental/lib/library_updater.dart:806:
emitter.computeAllNeededEntities();
Conflict resolution (computeAllNeededEntities was renamed from computeNeeds).

[Johnni Winther, 2014-12-11 13:07:18]

lgtm

[ahe, 2014-12-11 13:21:55]

Committed patchset #2 (id:40001) manually as 42283 (presubmit successful).