Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 760293002: dart2js: use named holes in boilerplate of new emitter. (Closed)

Created:
6 years ago by floitsch
Modified:
6 years ago
Reviewers:
karlklose, kasperl, sigurdm
CC:
reviews_dartlang.org, kasperl
Visibility:
Public.

Description

dart2js: use named holes in boilerplate of new emitter. Committed: https://code.google.com/p/dart/source/detail?r=42019

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -20 lines) Patch
M pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart View 5 chunks +20 lines, -20 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
floitsch
6 years ago (2014-11-27 13:40:07 UTC) #2
karlklose
STV!
6 years ago (2014-11-27 13:40:45 UTC) #4
floitsch
Committed patchset #1 (id:1) manually as 42019 (presubmit successful).
6 years ago (2014-11-27 13:43:44 UTC) #5
sigurdm
lgtm
6 years ago (2014-11-27 13:52:21 UTC) #6
kasperl
6 years ago (2014-11-27 14:29:25 UTC) #8
Message was sent while issue was closed. 
Very cool!

Powered by Google App Engine
This is Rietveld 408576698