Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 76013002: "Reverting 30387" -- failures on IE (Closed)

Created:
7 years, 1 month ago by Jennifer Messerly
Modified:
7 years, 1 month ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

"Reverting 30387" There are some issues on IE with pushState, Event.returnValue, and styles. Strangely, http://todomvc.com/architecture-examples/polymer/index.html which this was ported from has none of these issues. :| Committed: https://code.google.com/p/dart/source/detail?r=30388

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+713 lines, -1631 lines) Patch
M pkg/polymer/lib/src/build/linter.dart View 3 chunks +19 lines, -1 line 0 comments Download
M pkg/polymer/lib/src/declaration.dart View 3 chunks +7 lines, -34 lines 0 comments Download
M pkg/polymer/test/build/linter_test.dart View 6 chunks +15 lines, -7 lines 0 comments Download
D samples/third_party/todomvc/AUTHORS View 1 chunk +0 lines, -9 lines 0 comments Download
M samples/third_party/todomvc/LICENSE View 1 chunk +10 lines, -27 lines 0 comments Download
D samples/third_party/todomvc/PATENTS View 1 chunk +0 lines, -23 lines 0 comments Download
M samples/third_party/todomvc/README.md View 1 chunk +14 lines, -32 lines 0 comments Download
M samples/third_party/todomvc/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M samples/third_party/todomvc/test/listorder_test.dart View 3 chunks +8 lines, -13 lines 0 comments Download
M samples/third_party/todomvc/test/listorder_test.html View 2 chunks +5 lines, -7 lines 0 comments Download
M samples/third_party/todomvc/test/mainpage_test.dart View 2 chunks +15 lines, -25 lines 0 comments Download
M samples/third_party/todomvc/test/mainpage_test.html View 2 chunks +5 lines, -7 lines 0 comments Download
M samples/third_party/todomvc/test/markdone_shadow_test.html View 2 chunks +5 lines, -7 lines 0 comments Download
M samples/third_party/todomvc/test/markdone_test.dart View 4 chunks +24 lines, -15 lines 0 comments Download
M samples/third_party/todomvc/test/markdone_test.html View 2 chunks +5 lines, -7 lines 0 comments Download
D samples/third_party/todomvc/test/utils.dart View 1 chunk +0 lines, -23 lines 0 comments Download
A samples/third_party/todomvc/web/app.dart View 1 chunk +31 lines, -0 lines 0 comments Download
A samples/third_party/todomvc/web/app.html View 1 chunk +57 lines, -0 lines 0 comments Download
D samples/third_party/todomvc/web/app/app.css View 1 chunk +0 lines, -206 lines 0 comments Download
D samples/third_party/todomvc/web/app/bg.png View Binary file 0 comments Download
A + samples/third_party/todomvc/web/base.css View 10 chunks +106 lines, -44 lines 0 comments Download
A + samples/third_party/todomvc/web/bg.png View Binary file 0 comments Download
A samples/third_party/todomvc/web/editable_label.dart View 1 chunk +62 lines, -0 lines 0 comments Download
A samples/third_party/todomvc/web/editable_label.html View 1 chunk +19 lines, -0 lines 0 comments Download
D samples/third_party/todomvc/web/elements/td_input.dart View 1 chunk +0 lines, -24 lines 0 comments Download
D samples/third_party/todomvc/web/elements/td_input.html View 1 chunk +0 lines, -4 lines 0 comments Download
D samples/third_party/todomvc/web/elements/td_item.css View 1 chunk +0 lines, -161 lines 0 comments Download
D samples/third_party/todomvc/web/elements/td_item.dart View 1 chunk +0 lines, -45 lines 0 comments Download
D samples/third_party/todomvc/web/elements/td_item.html View 1 chunk +0 lines, -17 lines 0 comments Download
D samples/third_party/todomvc/web/elements/td_model.dart View 1 chunk +0 lines, -101 lines 0 comments Download
D samples/third_party/todomvc/web/elements/td_model.html View 1 chunk +0 lines, -3 lines 0 comments Download
D samples/third_party/todomvc/web/elements/td_todos.css View 1 chunk +0 lines, -267 lines 0 comments Download
D samples/third_party/todomvc/web/elements/td_todos.dart View 1 chunk +0 lines, -61 lines 0 comments Download
D samples/third_party/todomvc/web/elements/td_todos.html View 1 chunk +0 lines, -51 lines 0 comments Download
M samples/third_party/todomvc/web/index.html View 1 chunk +18 lines, -27 lines 0 comments Download
D samples/third_party/todomvc/web/lib-elements/polymer_localstorage.dart View 1 chunk +0 lines, -39 lines 0 comments Download
D samples/third_party/todomvc/web/lib-elements/polymer_localstorage.html View 1 chunk +0 lines, -27 lines 0 comments Download
D samples/third_party/todomvc/web/lib-elements/polymer_selection.dart View 1 chunk +0 lines, -66 lines 0 comments Download
D samples/third_party/todomvc/web/lib-elements/polymer_selection.html View 1 chunk +0 lines, -17 lines 0 comments Download
D samples/third_party/todomvc/web/lib-elements/polymer_selector.dart View 1 chunk +0 lines, -138 lines 0 comments Download
D samples/third_party/todomvc/web/lib-elements/polymer_selector.html View 1 chunk +0 lines, -47 lines 0 comments Download
D samples/third_party/todomvc/web/lib-elements/simple_router.dart View 1 chunk +0 lines, -39 lines 0 comments Download
D samples/third_party/todomvc/web/lib-elements/simple_router.html View 1 chunk +0 lines, -8 lines 0 comments Download
A samples/third_party/todomvc/web/model.dart View 1 chunk +69 lines, -0 lines 0 comments Download
A samples/third_party/todomvc/web/router_options.dart View 1 chunk +54 lines, -0 lines 0 comments Download
A + samples/third_party/todomvc/web/router_options.html View 1 chunk +4 lines, -1 line 0 comments Download
A samples/third_party/todomvc/web/todo_row.dart View 1 chunk +33 lines, -0 lines 0 comments Download
A samples/third_party/todomvc/web/todo_row.html View 1 chunk +127 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jennifer Messerly
7 years, 1 month ago (2013-11-19 05:15:55 UTC) #1
Jennifer Messerly
Committed patchset #1 manually as r30388 (presubmit successful).
7 years, 1 month ago (2013-11-19 05:16:37 UTC) #2
Jennifer Messerly
TBR'd because bots will soon break over this
7 years, 1 month ago (2013-11-19 05:17:37 UTC) #3
Siggi Cherem (dart-lang)
7 years, 1 month ago (2013-11-19 17:16:47 UTC) #4
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698