Fix date_time_test to not assume a particular slowness of running code.

Fix date_time_test to not assume a particular slowness of running code.

R=ricow@google.com

Committed: https://code.google.com/p/dart/source/detail?r=42083

[Lasse Reichstein Nielsen, 2014-12-03 06:51:06]

lrn@google.com changed reviewers:
+ ricow@google.com

[Lasse Reichstein Nielsen, 2014-12-03 06:51:07]

Remove the counter, and just run until Date.now() returns a time with a
different millisecond value.
That shouldn't take more than max(millisecond, timer granularity) time, but if
something is broken, it will hang forever.

[ricow1, 2014-12-03 06:55:46]

lgtm, suggestion for making this easier to debug in case we see a timeout on
this test

https://codereview.chromium.org/759753010/diff/1/tests/corelib/date_time_test...
File tests/corelib/date_time_test.dart (right):

https://codereview.chromium.org/759753010/diff/1/tests/corelib/date_time_test...
tests/corelib/date_time_test.dart:17: var t2 = new DateTime.now();
I would add a count, and print to stdout for every 1,000,000 iterations, that
way we actually know that we are waiting here if the test should time out,
something like:
print("Still waiting for time to move forward: t1 was
${t1.millisecondsSinceEpoch}, t2 was {t2.millisecondsSinceEpoch}, did $count
calls to DateTime.now()")

[Lasse Reichstein Nielsen, 2014-12-03 07:14:48]

https://codereview.chromium.org/759753010/diff/1/tests/corelib/date_time_test...
File tests/corelib/date_time_test.dart (right):

https://codereview.chromium.org/759753010/diff/1/tests/corelib/date_time_test...
tests/corelib/date_time_test.dart:17: var t2 = new DateTime.now();
On 2014/12/03 06:55:46, ricow1 wrote:
> I would add a count, and print to stdout for every 1,000,000 iterations, that
> way we actually know that we are waiting here if the test should time out,
> something like:
> print("Still waiting for time to move forward: t1 was
> ${t1.millisecondsSinceEpoch}, t2 was {t2.millisecondsSinceEpoch}, did $count
> calls to DateTime.now()")

Done.

[ricow1, 2014-12-03 07:17:10]

lgtm

[Lasse Reichstein Nielsen, 2014-12-03 07:21:06]

Committed patchset #2 (id:20001) manually as 42083 (presubmit successful).