Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 759223002: Fix HTTP IPv6 test (Closed)

Created:
6 years ago by Søren Gjesse
Modified:
6 years ago
Reviewers:
ricow1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix HTTP IPv6 test Use the loopback address ::1 to connect from the client. Using the IPv6 any address does not work on our Windows bots. This is also how the IPv6 socket tests connect. R=ricow@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=41981

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M tests/standalone/io/http_ipv6_test.dart View 2 chunks +9 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Gjesse
6 years ago (2014-11-26 08:49:19 UTC) #1
ricow1
lgtm
6 years ago (2014-11-26 08:50:26 UTC) #2
Søren Gjesse
6 years ago (2014-11-26 08:53:12 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41981 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698