Issue 758953002: cps-ir: Optimize identical used with constants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 758953002: cps-ir: Optimize identical used with constants. (Closed)

Created:
6 years ago by karlklose

Modified:
6 years ago

Reviewers:
sigurdm

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

cps-ir: Optimize identical used with constants. R=sigurdm@google.com Committed: https://code.google.com/p/dart/source/detail?r=41982

Patch Set 4 : Add an assert. #

Total comments: 1

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -23 lines)			Patch
	M	pkg/compiler/lib/src/cps_ir/constant_propagation.dart	View	1 2 3	1 chunk	+17 lines, -1 line	1 comment	Download
	M	tests/compiler/dart2js/js_backend_cps_ir_control_flow.dart	View	1 2	4 chunks	+25 lines, -22 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

karlklose

https://codereview.chromium.org/758953002/diff/60001/pkg/compiler/lib/src/cps_ir/constant_propagation.dart File pkg/compiler/lib/src/cps_ir/constant_propagation.dart (right): https://codereview.chromium.org/758953002/diff/60001/pkg/compiler/lib/src/cps_ir/constant_propagation.dart#newcode610 pkg/compiler/lib/src/cps_ir/constant_propagation.dart:610: _ConstnessLattice leftConst = getValue(node.left.definition); Indentation is correct, the highlighting ...

6 years ago (2014-11-26 08:16:01 UTC) #2

karlklose

6 years ago (2014-11-26 09:24:24 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 (id:60001) manually as 41982 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 758953002: cps-ir: Optimize identical used with constants. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : Add an assert. #

Messages