Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 758833004: Coalesce analysis server output messages into a single write call. (Closed)

Created:
6 years ago by Paul Berry
Modified:
6 years ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Coalesce analysis server output messages into a single write call. This ensures that only one call to stdout.write() is made per run of the event loop, so the output of the analysis server should not fall behind the rate of analysis. R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=41969

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -9 lines) Patch
M pkg/analysis_server/lib/src/channel/byte_stream_channel.dart View 3 chunks +99 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
To be applied after https://codereview.chromium.org/757013002/
6 years ago (2014-11-25 15:00:03 UTC) #2
scheglov
LGTM
6 years ago (2014-11-25 20:00:28 UTC) #3
Paul Berry
6 years ago (2014-11-25 20:39:53 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41969 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698