Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(738)

Issue 758123003: Workaround for canPlayType in Dartium (Closed)

Created:
6 years ago by vsm
Modified:
6 years ago
Reviewers:
Leaf, terry
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Workaround for canPlayType in Dartium BUG=http://dartbug.com/21702 R=leafp@google.com Committed: https://code.google.com/p/dart/source/detail?r=41967

Patch Set 1 #

Patch Set 2 : Add regression test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -16 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 2 chunks +5 lines, -5 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 4 chunks +11 lines, -11 lines 0 comments Download
M tests/html/audioelement_test.dart View 1 1 chunk +7 lines, -0 lines 0 comments Download
M tools/dom/scripts/htmlrenamer.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
vsm
6 years ago (2014-11-25 18:42:45 UTC) #2
vsm
Added regression test
6 years ago (2014-11-25 19:00:07 UTC) #3
Leaf
lgtm
6 years ago (2014-11-25 19:09:34 UTC) #4
vsm
6 years ago (2014-11-25 20:12:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 41967 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698