Issue 758103002: Clean up resolution of unlabeled break/continue targets.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 758103002: Clean up resolution of unlabeled break/continue targets. (Closed)

Created:
6 years ago by Paul Berry

Modified:
6 years ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Clean up resolution of unlabeled break/continue targets. Move the tracking of unlabeled break and continue targets from ResolverVisitor to ScopedVisitor, where it makes more sense, and add a new ImplicitLabelScope class that encapsulates the logic for it. R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=41965

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+117 lines, -78 lines)			Patch
	M	pkg/analyzer/lib/src/generated/element_resolver.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	pkg/analyzer/lib/src/generated/resolver.dart	View		17 chunks	+116 lines, -77 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Paul Berry

6 years ago (2014-11-25 18:40:04 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 41965 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages