Issue 757743004: Update errors during incremental resolution.

Issue 757743004: Update errors during incremental resolution. (Closed)

Created:
6 years ago by scheglov

Modified:
6 years ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Update errors during incremental resolution. Update offsets for the existing ones, remove some of them, add new. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=41966

Patch Set 1 #

Total comments: 2

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+548 lines, -255 lines)			Patch
M	pkg/analyzer/lib/src/generated/engine.dart	View	3 chunks	+16 lines, -5 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/error.dart	View	6 chunks	+8 lines, -16 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/error_verifier.dart	View	2 chunks	+22 lines, -13 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/incremental_resolver.dart	View	13 chunks	+345 lines, -208 lines	2 comments	Download
M	pkg/analyzer/test/generated/incremental_resolver_test.dart	View	5 chunks	+152 lines, -13 lines	0 comments	Download
M	pkg/analyzer/test/generated/resolver_test.dart	View	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/757743004/diff/1/pkg/analyzer/lib/src/generated/incremental_resolver.dart File pkg/analyzer/lib/src/generated/incremental_resolver.dart (right): https://codereview.chromium.org/757743004/diff/1/pkg/analyzer/lib/src/generated/incremental_resolver.dart#newcode1003 pkg/analyzer/lib/src/generated/incremental_resolver.dart:1003: List<AnalysisError> errors = _updateErrors(oldErrors, _newScanErrors); Given that we're ...

6 years ago (2014-11-25 14:53:58 UTC) #2

scheglov

Committed patchset #1 (id:1) manually as 41966 (presubmit successful).

6 years ago (2014-11-25 18:53:30 UTC) #3

scheglov

6 years ago (2014-11-25 18:54:11 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/757743004/diff/1/pkg/analyzer/lib/src/generat...
File pkg/analyzer/lib/src/generated/incremental_resolver.dart (right):

https://codereview.chromium.org/757743004/diff/1/pkg/analyzer/lib/src/generat...
pkg/analyzer/lib/src/generated/incremental_resolver.dart:1003:
List<AnalysisError> errors = _updateErrors(oldErrors, _newScanErrors);
On 2014/11/25 14:53:58, Brian Wilkerson wrote:
> Given that we're scanning and parsing the whole file, don't we need to replace
> all of the old errors rather than updating them?

Good idea!
Done.

Expand Messages | Collapse Messages