new onPriorityChanged event stream

new onPriorityChanged event stream

BUG=
R=brianwilkerson@google.com

Committed: https://code.google.com/p/dart/source/detail?r=41935

[danrubel, 2014-11-24 15:36:27]

danrubel@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2014-11-24 16:17:12]

LGTM

https://codereview.chromium.org/757613002/diff/20001/pkg/analysis_server/lib/...
File pkg/analysis_server/lib/src/analysis_server.dart (right):

https://codereview.chromium.org/757613002/diff/20001/pkg/analysis_server/lib/...
pkg/analysis_server/lib/src/analysis_server.dart:945: * A [PriorityChangeEvent]
indicates which sources are currently prioritized
I think it indicates that the list of priority changes has been changed.

https://codereview.chromium.org/757613002/diff/20001/pkg/analysis_server/lib/...
pkg/analysis_server/lib/src/analysis_server.dart:949: final Source firstSource;
Shouldn't this be a List<Source>? Or possibly a Map<AnalysisContext,
List<Source>>?

[danrubel, 2014-11-24 17:54:06]

https://codereview.chromium.org/757613002/diff/20001/pkg/analysis_server/lib/...
File pkg/analysis_server/lib/src/analysis_server.dart (right):

https://codereview.chromium.org/757613002/diff/20001/pkg/analysis_server/lib/...
pkg/analysis_server/lib/src/analysis_server.dart:945: * A [PriorityChangeEvent]
indicates which sources are currently prioritized
On 2014/11/24 16:17:11, Brian Wilkerson wrote:
> I think it indicates that the list of priority changes has been changed.

Cleaned up.

https://codereview.chromium.org/757613002/diff/20001/pkg/analysis_server/lib/...
pkg/analysis_server/lib/src/analysis_server.dart:949: final Source firstSource;
On 2014/11/24 16:17:11, Brian Wilkerson wrote:
> Shouldn't this be a List<Source>? Or possibly a Map<AnalysisContext,
> List<Source>>?

I only need the first source if there is one and I was keeping the event
minimal. If we find listeners need more information, we can enhance the API.

[danrubel, 2014-11-24 17:56:26]

Committed patchset #3 (id:40001) manually as 41935 (presubmit successful).

[Brian Wilkerson, 2014-11-24 18:14:38]

https://codereview.chromium.org/757613002/diff/20001/pkg/analysis_server/lib/...
File pkg/analysis_server/lib/src/analysis_server.dart (right):

https://codereview.chromium.org/757613002/diff/20001/pkg/analysis_server/lib/...
pkg/analysis_server/lib/src/analysis_server.dart:949: final Source firstSource;
> I only need the first source if there is one and I was keeping the event
> minimal. If we find listeners need more information, we can enhance the API.

Understood, and in general I agree with only doing what we need now (I
considered suggesting that we also include the old priority list but decided we
didn't need it yet and could cleanly add it later).

However, defining 'firstSource' means that we will always have to support it for
backward compatibility. In this case I think it would be better to support a
more general API and not have that constraint. (I suppose it won't be too
terrible to always need to have an accessor for the first element in the list,
but still...)