Issue 757193002: Fix for resolving super.method() invocations.

Issue 757193002: Fix for resolving super.method() invocations. (Closed)

Created:
6 years ago by scheglov

Modified:
6 years ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix for resolving super.method() invocations. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=41998

Patch Set 1 #

Total comments: 2

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+85 lines, -45 lines)			Patch
M	pkg/analyzer/lib/src/generated/error_verifier.dart	View	3 chunks	+37 lines, -22 lines	2 comments	Download
M	pkg/analyzer/lib/src/generated/incremental_resolver.dart	View	2 chunks	+5 lines, -2 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/resolver.dart	View	1 chunk	+22 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/static_type_analyzer.dart	View	4 chunks	+7 lines, -20 lines	0 comments	Download
M	pkg/analyzer/test/generated/incremental_resolver_test.dart	View	1 chunk	+13 lines, -0 lines	0 comments	Download
M	pkg/analyzer/test/generated/resolver_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/757193002/diff/1/pkg/analyzer/lib/src/generated/error_verifier.dart File pkg/analyzer/lib/src/generated/error_verifier.dart (right): https://codereview.chromium.org/757193002/diff/1/pkg/analyzer/lib/src/generated/error_verifier.dart#newcode433 pkg/analyzer/lib/src/generated/error_verifier.dart:433: _isInNativeClass = node.nativeClause != null; I must be ...

6 years ago (2014-11-26 15:30:51 UTC) #2

scheglov

Committed patchset #1 (id:1) manually as 41998 (presubmit successful).

6 years ago (2014-11-26 15:56:02 UTC) #3

scheglov

6 years ago (2014-11-26 15:56:18 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/757193002/diff/1/pkg/analyzer/lib/src/generat...
File pkg/analyzer/lib/src/generated/error_verifier.dart (right):

https://codereview.chromium.org/757193002/diff/1/pkg/analyzer/lib/src/generat...
pkg/analyzer/lib/src/generated/error_verifier.dart:433: _isInNativeClass =
node.nativeClause != null;
On 2014/11/26 15:30:51, Brian Wilkerson wrote:
> I must be missing something, but... Why did you inline this instead of just
> invoking visitClassDeclarationIncrementally at this point?

Well, in this class implementations of visitClassDeclarationIncrementally() and
corresponding code in visitClassDeclaration() can be shared. But not in
ResolverVisitor. So, I kept them separate here for consistency.

Replaced with an invocation now.

Expand Messages | Collapse Messages