Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 757013002: Use write instead of writeln for client/server communication. (Closed)

Created:
6 years ago by Paul Berry
Modified:
6 years ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Use write instead of writeln for client/server communication. We have observed that each string sent from the server to the client using stdout.write() takes at least one cycle of the event loop to complete. Since writeln() is implemented using two calls to write(), this means that streaming of messages to the client was almost always falling behind the actual rate of analysis, resulting in very annoying delays for the user. As a stopgap, send each message from server to client using a single call to write(). This doesn't completely solve the problem, but it should reduce its impact while we work on a better solution. R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=41959

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M pkg/analysis_server/lib/src/channel/byte_stream_channel.dart View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
6 years ago (2014-11-25 14:03:05 UTC) #2
scheglov
LGTM
6 years ago (2014-11-25 15:08:33 UTC) #3
Paul Berry
6 years ago (2014-11-25 16:06:35 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41959 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698