Remove computeMask from ConstantValue.

Remove computeMask from ConstantValue.

BUG=
R=karlklose@google.com

Committed: https://code.google.com/p/dart/source/detail?r=42360

[Johnni Winther, 2014-12-02 12:50:26]

johnniwinther@google.com changed reviewers:
+ karlklose@google.com

[karlklose, 2014-12-05 08:47:30]

LGTM, but I would prefer to have only one place mentioning  the constant visitor
and to inline the constant there.

https://codereview.chromium.org/756903005/diff/1/pkg/compiler/lib/src/constan...
File pkg/compiler/lib/src/constants/values.dart (left):

https://codereview.chromium.org/756903005/diff/1/pkg/compiler/lib/src/constan...
pkg/compiler/lib/src/constants/values.dart:748: ti.TypeMask computeMask(Compiler
compiler) {
I would prefer to remove the argument and rename the method to something like
'getTypeMask' and call 'accept' from there.

That way, we do not force the callsite to know about COMPUTE_TYPE_MASK.

https://codereview.chromium.org/756903005/diff/1/pkg/compiler/lib/src/constan...
File pkg/compiler/lib/src/constants/values.dart (right):

https://codereview.chromium.org/756903005/diff/1/pkg/compiler/lib/src/constan...
pkg/compiler/lib/src/constants/values.dart:71: accept(ConstantValueVisitor
visitor, arg);
Would it make sense to explicitly type this as 'Object' to indicate that it can
be anything?

https://codereview.chromium.org/756903005/diff/1/pkg/compiler/lib/src/inferre...
File pkg/compiler/lib/src/inferrer/inferrer_visitor.dart (right):

https://codereview.chromium.org/756903005/diff/1/pkg/compiler/lib/src/inferre...
pkg/compiler/lib/src/inferrer/inferrer_visitor.dart:754:
constantSystem.createDouble(node.value).accept(COMPUTE_TYPE_MASK, compiler));
Lone line (also below).

[Johnni Winther, 2014-12-15 11:15:28]

https://codereview.chromium.org/756903005/diff/1/pkg/compiler/lib/src/constan...
File pkg/compiler/lib/src/constants/values.dart (left):

https://codereview.chromium.org/756903005/diff/1/pkg/compiler/lib/src/constan...
pkg/compiler/lib/src/constants/values.dart:748: ti.TypeMask computeMask(Compiler
compiler) {
On 2014/12/05 08:47:29, karlklose wrote:
> I would prefer to remove the argument and rename the method to something like
> 'getTypeMask' and call 'accept' from there.
> 
> That way, we do not force the callsite to know about COMPUTE_TYPE_MASK.

We still need the compiler to compute the mask, so I don't see how we can remove
the argument.

https://codereview.chromium.org/756903005/diff/1/pkg/compiler/lib/src/constan...
File pkg/compiler/lib/src/constants/values.dart (right):

https://codereview.chromium.org/756903005/diff/1/pkg/compiler/lib/src/constan...
pkg/compiler/lib/src/constants/values.dart:71: accept(ConstantValueVisitor
visitor, arg);
On 2014/12/05 08:47:30, karlklose wrote:
> Would it make sense to explicitly type this as 'Object' to indicate that it
can
> be anything?

Ideally it should have been

<R, A> R accept(ConstantValueVisitor<R, A> visitor, A arg);

If find typing `arg` with `Object` indicates that the type of `arg` is not
variable.

[Johnni Winther, 2014-12-15 13:30:46]

https://codereview.chromium.org/756903005/diff/1/pkg/compiler/lib/src/constan...
File pkg/compiler/lib/src/constants/values.dart (left):

https://codereview.chromium.org/756903005/diff/1/pkg/compiler/lib/src/constan...
pkg/compiler/lib/src/constants/values.dart:748: ti.TypeMask computeMask(Compiler
compiler) {
On 2014/12/15 11:15:28, Johnni Winther wrote:
> On 2014/12/05 08:47:29, karlklose wrote:
> > I would prefer to remove the argument and rename the method to something
like
> > 'getTypeMask' and call 'accept' from there.
> > 
> > That way, we do not force the callsite to know about COMPUTE_TYPE_MASK.
> 
> We still need the compiler to compute the mask, so I don't see how we can
remove
> the argument.

Done.

[Johnni Winther, 2014-12-15 13:55:07]

Committed patchset #2 (id:20001) manually as 42360 (presubmit successful).