Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 756493002: pkg/http_server: move to multi-lib layout (Closed)

Created:
6 years, 1 month ago by kevmoo
Modified:
6 years ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

pkg/http_server: move to multi-lib layout Dependencies between features are now crystal clear R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=41936

Patch Set 1 #

Patch Set 2 : fixed long line #

Total comments: 4

Patch Set 3 : readme fixup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -58 lines) Patch
M pkg/http_server/CHANGELOG.md View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/http_server/README.md View 1 2 1 chunk +6 lines, -13 lines 0 comments Download
M pkg/http_server/lib/http_server.dart View 3 chunks +13 lines, -23 lines 0 comments Download
M pkg/http_server/lib/src/http_body.dart View 4 chunks +9 lines, -4 lines 0 comments Download
M pkg/http_server/lib/src/http_body_impl.dart View 3 chunks +14 lines, -5 lines 0 comments Download
D pkg/http_server/lib/src/http_multi_server.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M pkg/http_server/lib/src/http_multipart_form_data.dart View 2 chunks +9 lines, -2 lines 0 comments Download
M pkg/http_server/lib/src/http_multipart_form_data_impl.dart View 1 3 chunks +12 lines, -4 lines 0 comments Download
M pkg/http_server/lib/src/virtual_directory.dart View 1 chunk +7 lines, -1 line 0 comments Download
M pkg/http_server/lib/src/virtual_host.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/http_server/pubspec.yaml View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
kevmoo
6 years, 1 month ago (2014-11-24 01:37:01 UTC) #2
Søren Gjesse
lgtm https://codereview.chromium.org/756493002/diff/20001/pkg/http_server/CHANGELOG.md File pkg/http_server/CHANGELOG.md (right): https://codereview.chromium.org/756493002/diff/20001/pkg/http_server/CHANGELOG.md#newcode1 pkg/http_server/CHANGELOG.md:1: # 0.9.5+1 Why not just 0.9.6? https://codereview.chromium.org/756493002/diff/20001/pkg/http_server/pubspec.yaml File ...
6 years ago (2014-11-24 08:04:26 UTC) #3
kevmoo
https://codereview.chromium.org/756493002/diff/20001/pkg/http_server/CHANGELOG.md File pkg/http_server/CHANGELOG.md (right): https://codereview.chromium.org/756493002/diff/20001/pkg/http_server/CHANGELOG.md#newcode1 pkg/http_server/CHANGELOG.md:1: # 0.9.5+1 On 2014/11/24 08:04:26, Søren Gjesse wrote: > ...
6 years ago (2014-11-24 18:14:07 UTC) #4
kevmoo
6 years ago (2014-11-24 18:14:27 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 41936 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698