Issue 755883007: Handle IPv6 addresses for HTTP client requests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 755883007: Handle IPv6 addresses for HTTP client requests (Closed)

Created:
6 years ago by Søren Gjesse

Modified:
6 years ago

Reviewers:
Lasse Reichstein Nielsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Handle IPv6 addresses for HTTP client requests The Host header was not set correctly for HTTP requests when an IPv6 address was used. The square brackets surrounding the address was missing. BUG=http://dartbug.com/21698 R=lrn@google.com Committed: https://code.google.com/p/dart/source/detail?r=41980

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -1 line)			Patch
	M	sdk/lib/io/http_impl.dart	View		1 chunk	+4 lines, -1 line	0 comments	Download
	A	tests/standalone/io/http_ipv6_test.dart	View		1 chunk	+44 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

6 years ago (2014-11-26 07:30:40 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 41980 (presubmit successful).

Expand Messages | Collapse Messages