Issue 755743002: Incremental improvements in parameters and types matching.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 755743002: Incremental improvements in parameters and types matching. (Closed)

Created:
6 years ago by scheglov

Modified:
6 years ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Incremental improvements in parameters and types matching. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=41942

Patch Set 1 #

Total comments: 2

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+138 lines, -39 lines)			Patch
	M	pkg/analyzer/lib/src/generated/incremental_resolver.dart	View		8 chunks	+47 lines, -32 lines	0 comments	Download
	M	pkg/analyzer/test/generated/incremental_resolver_test.dart	View		7 chunks	+91 lines, -7 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/755743002/diff/1/pkg/analyzer/test/generated/incremental_resolver_test.dart File pkg/analyzer/test/generated/incremental_resolver_test.dart (right): https://codereview.chromium.org/755743002/diff/1/pkg/analyzer/test/generated/incremental_resolver_test.dart#newcode1458 pkg/analyzer/test/generated/incremental_resolver_test.dart:1458: void test_true_type_noTypeArguments_implyAllDynamic() { Perhaps test some false cases ...

6 years ago (2014-11-24 21:06:42 UTC) #2

scheglov

Committed patchset #1 (id:1) manually as 41942 (presubmit successful).

6 years ago (2014-11-24 21:11:38 UTC) #3

scheglov

6 years ago (2014-11-24 21:12:04 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/755743002/diff/1/pkg/analyzer/test/generated/...
File pkg/analyzer/test/generated/incremental_resolver_test.dart (right):

https://codereview.chromium.org/755743002/diff/1/pkg/analyzer/test/generated/...
pkg/analyzer/test/generated/incremental_resolver_test.dart:1458: void
test_true_type_noTypeArguments_implyAllDynamic() {
On 2014/11/24 21:06:41, Brian Wilkerson wrote:
> Perhaps test some false cases for types, such as
> 
> class A<T> {}
> A f() {}
> 
> and
> 
> class A<T> {}
> A<int> f() {}

Thank you.
Added.

Expand Messages | Collapse Messages