Issue 75543013: Make the stack_trace package print relative URLs for browser paths.

Issue 75543013: Make the stack_trace package print relative URLs for browser paths. (Closed)

Created:
7 years, 1 month ago by nweiz

Modified:
7 years, 1 month ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make the stack_trace package print relative URLs for browser paths. Prior to this, only console paths were printed as relative. R=rnystrom@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=30484

Patch Set 1 #

Total comments: 2

Patch Set 2 : code review #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -2 lines)			Patch
M	pkg/path/lib/path.dart	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	pkg/stack_trace/lib/src/frame.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	pkg/stack_trace/pubspec.yaml	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/stack_trace/test/frame_test.dart	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

LGTM! https://codereview.chromium.org/75543013/diff/1/pkg/stack_trace/lib/src/frame.dart File pkg/stack_trace/lib/src/frame.dart (right): https://codereview.chromium.org/75543013/diff/1/pkg/stack_trace/lib/src/frame.dart#newcode73 pkg/stack_trace/lib/src/frame.dart:73: if (path.style == path.Style.url) return path.relative(uri.toString()); Don't forget ...

7 years, 1 month ago (2013-11-20 20:21:21 UTC) #2

nweiz

https://codereview.chromium.org/75543013/diff/1/pkg/stack_trace/lib/src/frame.dart File pkg/stack_trace/lib/src/frame.dart (right): https://codereview.chromium.org/75543013/diff/1/pkg/stack_trace/lib/src/frame.dart#newcode73 pkg/stack_trace/lib/src/frame.dart:73: if (path.style == path.Style.url) return path.relative(uri.toString()); On 2013/11/20 20:21:22, ...

7 years, 1 month ago (2013-11-20 21:01:48 UTC) #3

nweiz

7 years, 1 month ago (2013-11-20 21:02:33 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r30484 (presubmit successful).

Expand Messages | Collapse Messages