Issue 755383002: Fix overflow check when shifting unboxed mints on 32-bit platforms, except on

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 755383002: Fix overflow check when shifting unboxed mints on 32-bit platforms, except on (Closed)

Created:
6 years ago by regis

Modified:
6 years ago

Reviewers:
zra

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Fix overflow check when shifting unboxed mints on 32-bit platforms, except on MIPS, which does not yet support unboxed mints (work in progress). Issue 21715. Add regression test. R=zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=42003

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+74 lines, -40 lines)			Patch
M	runtime/vm/intermediate_language_arm.cc	View	1	8 chunks	+39 lines, -36 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1	4 chunks	+16 lines, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/corelib/corelib.status	View	1	1 chunk	+1 line, -1 line	0 comments	Download
A	tests/corelib/regress_r21715_test.dart	View		1 chunk	+17 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

regis

6 years ago (2014-11-26 17:37:37 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as r42003 (presubmit successful).