Always enable RTI for incremental compilation.

Always enable RTI for incremental compilation.

R=johnniwinther@google.com

Committed: https://code.google.com/p/dart/source/detail?r=42036

[ahe, 2014-11-25 13:38:25]

ahe@google.com changed reviewers:
+ johnniwinther@google.com

[Johnni Winther, 2014-12-01 08:50:19]

lgtm

https://codereview.chromium.org/755223002/diff/20001/dart/pkg/dart2js_increme...
File dart/pkg/dart2js_incremental/lib/caching_compiler.dart (right):

https://codereview.chromium.org/755223002/diff/20001/dart/pkg/dart2js_increme...
dart/pkg/dart2js_incremental/lib/caching_compiler.dart:77:
backend.registerRuntimeType(
Add a TODO for me to add a global switch for always RTI.

https://codereview.chromium.org/755223002/diff/20001/dart/tests/try/web/incre...
File dart/tests/try/web/incremental_compilation_update_test.dart (right):

https://codereview.chromium.org/755223002/diff/20001/dart/tests/try/web/incre...
dart/tests/try/web/incremental_compilation_update_test.dart:869: import
'dart:collection';
Import in both ProgramResult's? The only difference should be HashMap, right?

https://codereview.chromium.org/755223002/diff/20001/dart/tests/try/web/incre...
dart/tests/try/web/incremental_compilation_update_test.dart:878: // TODO(ahe):
The incremental compiler magter ikke static tear-off closures.
Elaborate on what goes wrong.

[ahe, 2014-12-01 10:15:02]

Thank you, Johnni!

https://codereview.chromium.org/755223002/diff/20001/dart/pkg/dart2js_increme...
File dart/pkg/dart2js_incremental/lib/caching_compiler.dart (right):

https://codereview.chromium.org/755223002/diff/20001/dart/pkg/dart2js_increme...
dart/pkg/dart2js_incremental/lib/caching_compiler.dart:77:
backend.registerRuntimeType(
On 2014/12/01 08:50:19, Johnni Winther wrote:
> Add a TODO for me to add a global switch for always RTI.

Done.

https://codereview.chromium.org/755223002/diff/20001/dart/tests/try/web/incre...
File dart/tests/try/web/incremental_compilation_update_test.dart (right):

https://codereview.chromium.org/755223002/diff/20001/dart/tests/try/web/incre...
dart/tests/try/web/incremental_compilation_update_test.dart:869: import
'dart:collection';
On 2014/12/01 08:50:19, Johnni Winther wrote:
> Import in both ProgramResult's? The only difference should be HashMap, right?

Below I use the MockCompiler to serialize scope information. It doesn't handle
dart:collection, which I can work around by not importing dart:collection in the
second example. However, this relies on the fact that I don't yet detect changes
in imports and other library directives.

I have already uploaded another CL which gets rid of this import
(https://codereview.chromium.org/764533002/diff/1/dart/tests/try/web/increment...).

https://codereview.chromium.org/755223002/diff/20001/dart/tests/try/web/incre...
dart/tests/try/web/incremental_compilation_update_test.dart:878: // TODO(ahe):
The incremental compiler magter ikke static tear-off closures.
On 2014/12/01 08:50:19, Johnni Winther wrote:
> Elaborate on what goes wrong.

Since I've fixed it already, I'd rather not get into the details about precisely
what is wrong. TODO removed and fixed in
https://codereview.chromium.org/764533002/.

[ahe, 2014-12-01 10:32:06]

Committed patchset #4 (id:60001) manually as 42036 (presubmit successful).