Issue 755053002: Fix parsing of awaitable expressions with nested functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 755053002: Fix parsing of awaitable expressions with nested functions (Closed)

Created:
6 years ago by hausner

Modified:
6 years ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix parsing of awaitable expressions with nested functions “have seen await” flag must be properly saved and restored when parsing nested function (literals) inside an await expression. Fixes issue 21536 R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=41962

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -6 lines)			Patch
M	runtime/vm/parser.h	View	3 chunks	+3 lines, -4 lines	0 comments	Download
M	runtime/vm/parser.cc	View	2 chunks	+1 line, -2 lines	0 comments	Download
A	tests/language/await_regression_test.dart	View	1 chunk	+22 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

hausner

6 years ago (2014-11-25 18:13:53 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as r41962 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages