Issue 21662. Fix 'Sort Members' when both directives and declarations are updated.

Issue 21662. Fix 'Sort Members' when both directives and declarations are updated.

R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21662

Committed: https://code.google.com/p/dart/source/detail?r=41926

[Paul Berry, 2014-11-24 14:25:00]

lgtm

https://codereview.chromium.org/753883003/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/services/correction/sort_members.dart (right):

https://codereview.chromium.org/753883003/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/services/correction/sort_members.dart:65:
_sortUnitDirectives();
It would be nice to have a short comment above this line explaining why it needs
to come last, e.g.

"Must sort unit directives last because it may insert newlines, which would
confuse the offsets used by the other sort functions"

[scheglov, 2014-11-24 15:50:00]

https://codereview.chromium.org/753883003/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/services/correction/sort_members.dart (right):

https://codereview.chromium.org/753883003/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/services/correction/sort_members.dart:65:
_sortUnitDirectives();
On 2014/11/24 14:24:59, Paul Berry wrote:
> It would be nice to have a short comment above this line explaining why it
needs
> to come last, e.g.
> 
> "Must sort unit directives last because it may insert newlines, which would
> confuse the offsets used by the other sort functions"

Done.

[scheglov, 2014-11-24 15:50:24]

Committed patchset #1 (id:1) manually as 41926 (presubmit successful).