Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 753323002: Skip more of event loop dispatch in invocation fuzzer to avoid triggering runtime errors we cannot … (Closed)

Created:
6 years ago by rmacnak
Modified:
6 years ago
Reviewers:
regis, Ivan Posva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Skip more of event loop dispatch in invocation fuzzer to avoid triggering runtime errors we cannot catch. BUG=http://dartbug.com/21473 R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=42054

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M tests/lib/mirrors/invocation_fuzz_test.dart View 1 chunk +5 lines, -0 lines 2 comments Download

Messages

Total messages: 7 (2 generated)
rmacnak
6 years ago (2014-11-24 20:38:34 UTC) #2
regis
LGTM
6 years ago (2014-12-01 22:38:01 UTC) #3
rmacnak
Committed patchset #1 (id:1) manually as 42054 (presubmit successful).
6 years ago (2014-12-01 22:56:35 UTC) #4
Ivan Posva
DBC -ip https://codereview.chromium.org/753323002/diff/1/tests/lib/mirrors/invocation_fuzz_test.dart File tests/lib/mirrors/invocation_fuzz_test.dart (right): https://codereview.chromium.org/753323002/diff/1/tests/lib/mirrors/invocation_fuzz_test.dart#newcode30 tests/lib/mirrors/invocation_fuzz_test.dart:30: 'dart.isolate._startIsolate', Are these visible through mirrors? Probably ...
6 years ago (2014-12-02 07:40:16 UTC) #6
rmacnak
6 years ago (2014-12-03 21:59:23 UTC) #7
Message was sent while issue was closed.
https://codereview.chromium.org/753323002/diff/1/tests/lib/mirrors/invocation...
File tests/lib/mirrors/invocation_fuzz_test.dart (right):

https://codereview.chromium.org/753323002/diff/1/tests/lib/mirrors/invocation...
tests/lib/mirrors/invocation_fuzz_test.dart:30: 'dart.isolate._startIsolate',
On 2014/12/02 07:40:16, Ivan Posva wrote:
> Are these visible through mirrors? Probably should not be...

Hiding many of these in another CL.

Powered by Google App Engine
This is Rietveld 408576698