Support enum keys in maps in messages.

Support enum keys in maps in messages.

Make enum classes implement hashCode, rather than use the identity hash code, so that they can be portably serialized.

BUG=dart:21675
R=asiva@google.com, lrn@google.com

Committed: https://code.google.com/p/dart/source/detail?r=44278

[koda, 2014-11-24 17:35:22]

After discussion with iposva, changed to use hash code of the string
representation, to reduce collisions in maps with keys from several enum classes
and/or plain ints.

Also added unit test.

[Lasse Reichstein Nielsen, 2014-11-26 14:29:28]

https://codereview.chromium.org/752123003/diff/40001/tests/isolate/message_en...
File tests/isolate/message_enum_test.dart (right):

https://codereview.chromium.org/752123003/diff/40001/tests/isolate/message_en...
tests/isolate/message_enum_test.dart:22: }
Try this from another isolate too:

main() {
  var p;
  p = new RawReceivePort((map) {
    Expect.equals(1, map.keys.length);
    Expect.equals(42, map.values.first);
    var key = map.keys.first;
    Expect.equals(42, map[key]);
     p.close();
  });
  Isolate.spawn(sendIt, p.sendPort);
}

void sendIt(port) {
  var map = { Foo.BAR: 42 };
  port.send(map);
}

 21   p.sendPort.send(map);
 22 }

[koda, 2014-11-26 14:37:52]

PTAL

https://codereview.chromium.org/752123003/diff/40001/tests/isolate/message_en...
File tests/isolate/message_enum_test.dart (right):

https://codereview.chromium.org/752123003/diff/40001/tests/isolate/message_en...
tests/isolate/message_enum_test.dart:22: }
On 2014/11/26 14:29:27, Lasse Reichstein Nielsen wrote:
> Try this from another isolate too:
> 
> main() {
>   var p;
>   p = new RawReceivePort((map) {
>     Expect.equals(1, map.keys.length);
>     Expect.equals(42, map.values.first);
>     var key = map.keys.first;
>     Expect.equals(42, map[key]);
>      p.close();
>   });
>   Isolate.spawn(sendIt, p.sendPort);
> }
> 
> void sendIt(port) {
>   var map = { Foo.BAR: 42 };
>   port.send(map);
> }
> 
>  21   p.sendPort.send(map);
>  22 }

Done.

[koda, 2014-12-02 19:43:23]

On 2014/11/26 14:37:52, koda wrote:
> PTAL
> 
>
https://codereview.chromium.org/752123003/diff/40001/tests/isolate/message_en...
> File tests/isolate/message_enum_test.dart (right):
> 
>
https://codereview.chromium.org/752123003/diff/40001/tests/isolate/message_en...
> tests/isolate/message_enum_test.dart:22: }
> On 2014/11/26 14:29:27, Lasse Reichstein Nielsen wrote:
> > Try this from another isolate too:
> > 
> > main() {
> >   var p;
> >   p = new RawReceivePort((map) {
> >     Expect.equals(1, map.keys.length);
> >     Expect.equals(42, map.values.first);
> >     var key = map.keys.first;
> >     Expect.equals(42, map[key]);
> >      p.close();
> >   });
> >   Isolate.spawn(sendIt, p.sendPort);
> > }
> > 
> > void sendIt(port) {
> >   var map = { Foo.BAR: 42 };
> >   port.send(map);
> > }
> > 
> >  21   p.sendPort.send(map);
> >  22 }
> 
> Done.

Ping.

[koda, 2014-12-09 15:19:21]

Ping again...

[Lasse Reichstein Nielsen, 2014-12-23 13:36:28]

It LGTM, but what do I know about VM stuff :)
Ivan?

[koda, 2015-03-05 16:33:32]

koda@google.com changed reviewers:
+ asiva@google.com
- iposva@google.com

[koda, 2015-03-05 16:33:51]

-iposva
+asiva

[siva, 2015-03-05 23:42:07]

lgtm

https://codereview.chromium.org/752123003/diff/60001/tests/isolate/message_en...
File tests/isolate/message_enum_test.dart (right):

https://codereview.chromium.org/752123003/diff/60001/tests/isolate/message_en...
tests/isolate/message_enum_test.dart:1: // Copyright (c) 2014, the Dart project
authors.  Please see the AUTHORS file
A new file so use 2015.

[koda, 2015-03-06 01:43:04]

https://codereview.chromium.org/752123003/diff/60001/tests/isolate/message_en...
File tests/isolate/message_enum_test.dart (right):

https://codereview.chromium.org/752123003/diff/60001/tests/isolate/message_en...
tests/isolate/message_enum_test.dart:1: // Copyright (c) 2014, the Dart project
authors.  Please see the AUTHORS file
On 2015/03/05 23:42:07, siva wrote:
> A new file so use 2015.

I actually wrote it in 2014 :)

[koda, 2015-03-06 02:57:43]

Committed patchset #4 (id:60001) manually as r44278 (presubmit successful).