Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 750953005: When the same contents is set for a source, we still need to reset its modification time. (Closed)

Created:
6 years ago by scheglov
Modified:
6 years ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

When the same contents is set for a source, we still need to reset its modification time. Otherwise quick add/remove a character causes non-incremental resolution. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=42120

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -12 lines) Patch
M pkg/analyzer/lib/src/generated/engine.dart View 3 chunks +10 lines, -4 lines 0 comments Download
M pkg/analyzer/test/generated/engine_test.dart View 4 chunks +24 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
6 years ago (2014-12-04 22:27:13 UTC) #1
Brian Wilkerson
LGTM
6 years ago (2014-12-04 22:30:10 UTC) #2
scheglov
6 years ago (2014-12-04 22:31:08 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 42120 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698