Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 750653002: Checked mode fixes. (Closed)

Created:
6 years, 1 month ago by ahe
Modified:
6 years ago
CC:
reviews_dartlang.org, Bill Hesse, kasperl, lukechurch
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Merged with r41950. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -31 lines) Patch
M dart/pkg/compiler/lib/src/scanner/class_element_parser.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M dart/pkg/dart2js_incremental/lib/library_updater.dart View 6 chunks +10 lines, -24 lines 0 comments Download
M dart/tests/try/web/incremental_compilation_update_test.dart View 2 chunks +5 lines, -1 line 0 comments Download
M dart/tools/bots/compiler.py View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ahe
6 years, 1 month ago (2014-11-21 18:27:30 UTC) #2
Johnni Winther
lgtm
6 years ago (2014-11-24 10:33:14 UTC) #3
Bill Hesse
https://codereview.chromium.org/750653002/diff/1/dart/tests/try/web/incremental_compilation_update_test.dart File dart/tests/try/web/incremental_compilation_update_test.dart (right): https://codereview.chromium.org/750653002/diff/1/dart/tests/try/web/incremental_compilation_update_test.dart#newcode1028 dart/tests/try/web/incremental_compilation_update_test.dart:1028: ..appendText("Full program #${testCount++}:")); two-space indent for cascades, according to ...
6 years ago (2014-11-24 11:50:14 UTC) #5
ahe
Thank you, Johnni and Bill! https://codereview.chromium.org/750653002/diff/1/dart/tests/try/web/incremental_compilation_update_test.dart File dart/tests/try/web/incremental_compilation_update_test.dart (right): https://codereview.chromium.org/750653002/diff/1/dart/tests/try/web/incremental_compilation_update_test.dart#newcode1028 dart/tests/try/web/incremental_compilation_update_test.dart:1028: ..appendText("Full program #${testCount++}:")); On ...
6 years ago (2014-11-25 13:50:25 UTC) #6
ahe
6 years ago (2014-11-25 13:53:06 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 41951 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698