Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issue 750083002: Matching for import/export/part directives. (Closed)

Created:
6 years, 1 month ago by scheglov
Modified:
6 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Matching for import/export/part directives. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=41915

Patch Set 1 #

Total comments: 2

Patch Set 2 : Match export combinators #

Unified diffs Side-by-side diffs Delta from patch set Stats (+370 lines, -106 lines) Patch
M pkg/analyzer/lib/src/generated/incremental_resolver.dart View 1 13 chunks +100 lines, -94 lines 0 comments Download
M pkg/analyzer/test/generated/incremental_resolver_test.dart View 1 7 chunks +270 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
6 years, 1 month ago (2014-11-21 18:32:16 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/750083002/diff/1/pkg/analyzer/lib/src/generated/incremental_resolver.dart File pkg/analyzer/lib/src/generated/incremental_resolver.dart (right): https://codereview.chromium.org/750083002/diff/1/pkg/analyzer/lib/src/generated/incremental_resolver.dart#newcode171 pkg/analyzer/lib/src/generated/incremental_resolver.dart:171: visitExportDirective(ExportDirective node) { Export directives also have combinators. ...
6 years, 1 month ago (2014-11-21 19:50:41 UTC) #2
scheglov
https://codereview.chromium.org/750083002/diff/1/pkg/analyzer/lib/src/generated/incremental_resolver.dart File pkg/analyzer/lib/src/generated/incremental_resolver.dart (right): https://codereview.chromium.org/750083002/diff/1/pkg/analyzer/lib/src/generated/incremental_resolver.dart#newcode171 pkg/analyzer/lib/src/generated/incremental_resolver.dart:171: visitExportDirective(ExportDirective node) { On 2014/11/21 19:50:41, Brian Wilkerson wrote: ...
6 years, 1 month ago (2014-11-21 20:07:18 UTC) #3
scheglov
6 years, 1 month ago (2014-11-21 20:07:46 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 41915 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698