Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 74953005: Fix https://code.google.com/p/dart/issues/detail?id=15132, by not doing load elimination on typed a… (Closed)

Created:
7 years, 1 month ago by ngeoffray
Modified:
7 years, 1 month ago
Reviewers:
lukas
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M sdk/lib/_internal/compiler/implementation/js_backend/backend.dart View 1 chunk +7 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/optimize.dart View 1 chunk +3 lines, -0 lines 0 comments Download
A tests/lib/typed_data/typed_data_load_test.dart View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ngeoffray
7 years, 1 month ago (2013-11-18 15:06:21 UTC) #1
lukas
LGTM!
7 years, 1 month ago (2013-11-18 15:50:00 UTC) #2
ngeoffray
7 years, 1 month ago (2013-11-18 15:52:52 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r30353 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698