Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 749193002: Work around erroneous GCC report about potentially clobbered variable. (Closed)

Created:
6 years ago by zerny-google
Modified:
6 years ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Work around erroneous GCC report about potentially clobbered variable. R=vegorov@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=41924

Patch Set 1 #

Patch Set 2 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M runtime/vm/flow_graph_inliner.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
zerny-google
6 years ago (2014-11-24 06:31:46 UTC) #1
Vyacheslav Egorov (Google)
LGTM Please add a comment above this variable that volatile is a workaround for GCC ...
6 years ago (2014-11-24 07:18:50 UTC) #2
zerny-google
6 years ago (2014-11-24 08:57:18 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 41924 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698