Issue 747463002: Fix allocation stats bug on ARM; add unit test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 747463002: Fix allocation stats bug on ARM; add unit test. (Closed)

Created:
6 years, 1 month ago by koda

Modified:
6 years, 1 month ago

Reviewers:
zra

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix allocation stats bug on ARM; add unit test. Also add sanity checks to ClassHeapStats. Array allocation stub was using an address instead of a size for the allocation size. R=zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=41862

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+71 lines, -8 lines)			Patch
M	runtime/vm/class_table.h	View	1 2	2 chunks	+9 lines, -0 lines	0 comments	Download
M	runtime/vm/class_table.cc	View	1 2	4 chunks	+12 lines, -0 lines	0 comments	Download
M	runtime/vm/heap_test.cc	View	1 2	1 chunk	+40 lines, -0 lines	0 comments	Download
M	runtime/vm/stub_code_arm.cc	View		1 chunk	+10 lines, -8 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

zra

lgtm with sanity check in class table as discussed. https://codereview.chromium.org/747463002/diff/20001/runtime/vm/heap_test.cc File runtime/vm/heap_test.cc (right): https://codereview.chromium.org/747463002/diff/20001/runtime/vm/heap_test.cc#newcode196 runtime/vm/heap_test.cc:196: ...

6 years, 1 month ago (2014-11-20 19:05:18 UTC) #2

koda

Also added ASSERTs of non-negativity. https://codereview.chromium.org/747463002/diff/20001/runtime/vm/heap_test.cc File runtime/vm/heap_test.cc (right): https://codereview.chromium.org/747463002/diff/20001/runtime/vm/heap_test.cc#newcode196 runtime/vm/heap_test.cc:196: Dart_Handle result2 = Dart_Invoke(h_lib, ...

6 years, 1 month ago (2014-11-20 19:19:53 UTC) #3

koda

6 years, 1 month ago (2014-11-20 19:20:38 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as r41862 (presubmit successful).

Expand Messages | Collapse Messages