Add a test for pub's async_await compiler.

Add a test for pub's async_await compiler.

This changes the invocation of async_compile.dart to take an output
directory as a command-line argument.

R=ricow@google.com, rnystrom@google.com

Committed: https://code.google.com/p/dart/source/detail?r=42079

[nweiz, 2014-12-02 00:56:14]

nweiz@google.com changed reviewers:
+ rnystrom@google.com

[nweiz, 2014-12-02 00:56:15]

This test should catch issues like the one Rico ran into as soon as they appear.

[ricow1, 2014-12-02 06:25:45]

ricow@google.com changed reviewers:
+ ricow@google.com

[ricow1, 2014-12-02 06:25:45]

lgtm

https://codereview.chromium.org/747273003/diff/1/sdk/lib/_internal/pub/test/a...
File sdk/lib/_internal/pub/test/async_compile_test.dart (right):

https://codereview.chromium.org/747273003/diff/1/sdk/lib/_internal/pub/test/a...
sdk/lib/_internal/pub/test/async_compile_test.dart:20: p.join(sandboxDir,
"pub_generated"),
what is sandboxDir here? A temp dir? will it be cleaned up afterwards?
The reason I am asking is, that if I run:
tools/test.py -mrelease pub

I get 3 leftover pub testing folders in /tmp

[Bob Nystrom, 2014-12-02 19:15:51]

https://codereview.chromium.org/747273003/diff/1/sdk/lib/_internal/pub/bin/as...
File sdk/lib/_internal/pub/bin/async_compile.dart (right):

https://codereview.chromium.org/747273003/diff/1/sdk/lib/_internal/pub/bin/as...
sdk/lib/_internal/pub/bin/async_compile.dart:99: "<generated dir> <build dir>");
Is the build dir only used for the snapshot now? If so, how about making
"--snapshot-build-dir" an option where the directory is the option's value?

https://codereview.chromium.org/747273003/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/io.dart (right):

https://codereview.chromium.org/747273003/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/io.dart:492: /// Returns the path to the root of
pub.
"...'s sources in the Dart repo."

https://codereview.chromium.org/747273003/diff/1/sdk/lib/_internal/pub/test/a...
File sdk/lib/_internal/pub/test/async_compile_test.dart (right):

https://codereview.chromium.org/747273003/diff/1/sdk/lib/_internal/pub/test/a...
sdk/lib/_internal/pub/test/async_compile_test.dart:20: p.join(sandboxDir,
"pub_generated"),
On 2014/12/02 06:25:45, ricow1 wrote:
> what is sandboxDir here? A temp dir? will it be cleaned up afterwards?

Yes, it should be.

> The reason I am asking is, that if I run:
> tools/test.py -mrelease pub
> 
> I get 3 leftover pub testing folders in /tmp

That sounds like a bug either in scheduled_test or pub's test infrastructure. :(

[nweiz, 2014-12-02 20:52:57]

Code review changes

[nweiz, 2014-12-02 21:14:13]

https://codereview.chromium.org/747273003/diff/1/sdk/lib/_internal/pub/bin/as...
File sdk/lib/_internal/pub/bin/async_compile.dart (right):

https://codereview.chromium.org/747273003/diff/1/sdk/lib/_internal/pub/bin/as...
sdk/lib/_internal/pub/bin/async_compile.dart:99: "<generated dir> <build dir>");
On 2014/12/02 19:15:50, Bob Nystrom wrote:
> Is the build dir only used for the snapshot now? If so, how about making
> "--snapshot-build-dir" an option where the directory is the option's value?

Done.

https://codereview.chromium.org/747273003/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/io.dart (right):

https://codereview.chromium.org/747273003/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/io.dart:492: /// Returns the path to the root of
pub.
On 2014/12/02 19:15:50, Bob Nystrom wrote:
> "...'s sources in the Dart repo."

Done.

[Bob Nystrom, 2014-12-02 23:36:54]

LGTM!

[nweiz, 2014-12-03 00:11:44]

Committed patchset #3 (id:40001) manually as 42079 (presubmit successful).