Issue 747153002: Resolve not-equals operator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 747153002: Resolve not-equals operator (Closed)

Created:
6 years, 1 month ago by Brian Wilkerson

Modified:
6 years ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Resolve not-equals operator R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=41920

Patch Set 1 #

Total comments: 1

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+67 lines, -29 lines)			Patch
	M	pkg/analyzer/lib/src/generated/element_resolver.dart	View		1 chunk	+32 lines, -27 lines	1 comment	Download
	M	pkg/analyzer/test/generated/resolver_test.dart	View		2 chunks	+35 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

scheglov

LGTM https://codereview.chromium.org/747153002/diff/1/pkg/analyzer/lib/src/generated/element_resolver.dart File pkg/analyzer/lib/src/generated/element_resolver.dart (right): https://codereview.chromium.org/747153002/diff/1/pkg/analyzer/lib/src/generated/element_resolver.dart#newcode177 pkg/analyzer/lib/src/generated/element_resolver.dart:177: void _resolveBinaryExpression(BinaryExpression node, String methodName) { Sort members?

6 years, 1 month ago (2014-11-21 21:18:54 UTC) #4

Brian Wilkerson

6 years, 1 month ago (2014-11-21 21:23:48 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 41920 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages