Issue 747023002: Undo changes to type propagation and canonicalization from my previous CL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 747023002: Undo changes to type propagation and canonicalization from my previous CL. (Closed)

Created:
6 years, 1 month ago by Florian Schneider

Modified:
6 years, 1 month ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Undo changes to type propagation and canonicalization from my previous CL. They triggered a bug with missing deoptimization environments in unboxing of int32. TBR=vegorov@google.com Committed: https://code.google.com/p/dart/source/detail?r=41900

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -20 lines)			Patch
M	runtime/vm/compiler.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	runtime/vm/flow_graph_type_propagator.cc	View	2 chunks	+1 line, -6 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	1 chunk	+2 lines, -9 lines	0 comments	Download

Total messages: 2 (0 generated)

Florian Schneider

6 years, 1 month ago (2014-11-21 13:31:41 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as r41900 (presubmit successful).