Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 746503002: Move incremental scanner to separate file (Closed)

Created:
6 years, 1 month ago by Brian Wilkerson
Modified:
6 years, 1 month ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Move incremental scanner to separate file R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=41856

Patch Set 1 #

Patch Set 2 : Add new files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+844 lines, -830 lines) Patch
M pkg/analyzer/lib/src/generated/engine.dart View 1 chunk +1 line, -0 lines 0 comments Download
A pkg/analyzer/lib/src/generated/incremental_scanner.dart View 1 1 chunk +254 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/scanner.dart View 2 chunks +0 lines, -247 lines 0 comments Download
A pkg/analyzer/test/generated/incremental_scanner_test.dart View 1 1 chunk +563 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analyzer/test/generated/scanner_test.dart View 9 chunks +23 lines, -580 lines 0 comments Download
M pkg/analyzer/test/generated/test_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Brian Wilkerson
6 years, 1 month ago (2014-11-20 17:42:03 UTC) #2
scheglov
LGTM
6 years, 1 month ago (2014-11-20 17:53:27 UTC) #3
Brian Wilkerson
6 years, 1 month ago (2014-11-20 17:55:03 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 41856 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698