Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 745023002: - Properly canonicalize enum values. (Closed)

Created:
6 years, 1 month ago by Ivan Posva
Modified:
6 years, 1 month ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix dartbug.com/21671: - Properly canonicalize enum values. - Ensure canonical objects are deserialized properly. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=41874

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -1 line) Patch
M runtime/vm/class_finalizer.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M runtime/vm/snapshot.cc View 1 chunk +1 line, -1 line 0 comments Download
A tests/language/enum_const_test.dart View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Ivan Posva
6 years, 1 month ago (2014-11-20 21:58:25 UTC) #2
siva
lgtm
6 years, 1 month ago (2014-11-20 23:29:47 UTC) #3
Ivan Posva
6 years, 1 month ago (2014-11-20 23:31:16 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r41874 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698