Infrastructure for testing IncrementalResolver.

Infrastructure for testing IncrementalResolver.

It should help in tesing incremental resolution of any changed node.

R=brianwilkerson@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=41854

[Brian Wilkerson, 2014-11-20 15:38:39]

LGTM

https://codereview.chromium.org/744553002/diff/1/pkg/analyzer/test/generated/...
File pkg/analyzer/test/generated/incremental_resolver_test.dart (right):

https://codereview.chromium.org/744553002/diff/1/pkg/analyzer/test/generated/...
pkg/analyzer/test/generated/incremental_resolver_test.dart:319: AstNode oldNode
= _findNodeAt(unit, offset, predicate);
This concerns me because it doesn't necessarily match the behavior of the
incremental parser. I suppose that we can be careful in these tests to always
replace text starting at the offset of the node that the incremental parser
would have replaced, but it seems highly error prone. We should revisit this
test framework at some point.

https://codereview.chromium.org/744553002/diff/1/pkg/analyzer/test/generated/...
pkg/analyzer/test/generated/incremental_resolver_test.dart:1382: void
_safeT(DartType a, DartType b) {
These single letter abbreviations ("T" for type, "N" for node, etc.) make the
code very hard to read.

[scheglov, 2014-11-20 16:13:17]

https://codereview.chromium.org/744553002/diff/1/pkg/analyzer/test/generated/...
File pkg/analyzer/test/generated/incremental_resolver_test.dart (right):

https://codereview.chromium.org/744553002/diff/1/pkg/analyzer/test/generated/...
pkg/analyzer/test/generated/incremental_resolver_test.dart:319: AstNode oldNode
= _findNodeAt(unit, offset, predicate);
On 2014/11/20 15:38:39, Brian Wilkerson wrote:
> This concerns me because it doesn't necessarily match the behavior of the
> incremental parser. I suppose that we can be careful in these tests to always
> replace text starting at the offset of the node that the incremental parser
> would have replaced, but it seems highly error prone. We should revisit this
> test framework at some point.

We need to discuss this offline.

https://codereview.chromium.org/744553002/diff/1/pkg/analyzer/test/generated/...
pkg/analyzer/test/generated/incremental_resolver_test.dart:1382: void
_safeT(DartType a, DartType b) {
On 2014/11/20 15:38:39, Brian Wilkerson wrote:
> These single letter abbreviations ("T" for type, "N" for node, etc.) make the
> code very hard to read.

Thank you.
I forgot to rename these.

Fixed.

[scheglov, 2014-11-20 16:14:52]

Committed patchset #1 (id:1) manually as 41854 (presubmit successful).