Issue 744323005: Don't check against __BYTE_ORDER__ when not defined.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 744323005: Don't check against __BYTE_ORDER__ when not defined. (Closed)

Created:
6 years ago by zerny-google

Modified:
6 years ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Don't check against __BYTE_ORDER__ when not defined. It appears that clang in Xcode does yet define __BYTE_ORDER__. TBR=fschneider@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=41984

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	runtime/vm/regexp.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

zerny-google

Committed patchset #1 (id:1) manually as 41984 (presubmit successful).

6 years ago (2014-11-26 09:54:21 UTC) #1

Message was sent while issue was closed.

lgtm