Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 744043002: discard code completion cache if context or other sources change (Closed)

Created:
6 years, 1 month ago by danrubel
Modified:
6 years, 1 month ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

discard code completion cache if context or other sources change BUG= R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=41860

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+361 lines, -4 lines) Patch
M pkg/analysis_server/lib/src/domain_completion.dart View 6 chunks +84 lines, -4 lines 0 comments Download
M pkg/analysis_server/test/domain_completion_test.dart View 3 chunks +277 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
danrubel
6 years, 1 month ago (2014-11-20 14:38:30 UTC) #2
scheglov
LGTM
6 years, 1 month ago (2014-11-20 15:56:48 UTC) #3
danrubel
6 years, 1 month ago (2014-11-20 18:40:48 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 41860 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698