Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 742273005: Annotate remaining analyzer/analysis server tests with "@ReflectiveTestCase()" (Closed)

Created:
6 years ago by Paul Berry
Modified:
6 years ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Annotate remaining analyzer/analysis server tests with "@ReflectiveTestCase()" In r42181, I failed to notice the need to annotate these tests because they aren't currently being run under dart2js (most likely due to slowness). I've modified runReflectiveTests() to check for the presence of the annotation before running the tests, in order to ensure that all the classes are properly annotated now, and so that we won't forget to add annotations in the future. R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=42185

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -0 lines) Patch
M pkg/analysis_server/test/protocol_server_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/reflective_tests.dart View 1 chunk +8 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/all_the_rest_test.dart View 31 chunks +31 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/compile_time_error_code_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/test/generated/element_test.dart View 14 chunks +14 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/engine_test.dart View 23 chunks +23 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/incremental_resolver_test.dart View 4 chunks +4 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/non_error_resolver_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 26 chunks +26 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/static_type_warning_code_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/test/generated/static_warning_code_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/test/reflective_tests.dart View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
6 years ago (2014-12-08 21:24:35 UTC) #2
scheglov
LGTM
6 years ago (2014-12-08 21:26:48 UTC) #3
Paul Berry
6 years ago (2014-12-08 21:36:02 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 42185 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698