Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 742103003: Update 'nameOffset' for elements during incremental analysis. (Closed)

Created:
6 years, 1 month ago by scheglov
Modified:
6 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Update 'nameOffset' for elements during incremental analysis. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=41857

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -62 lines) Patch
M pkg/analyzer/lib/src/generated/element.dart View 4 chunks +10 lines, -5 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 5 chunks +39 lines, -13 lines 0 comments Download
M pkg/analyzer/lib/src/generated/incremental_resolver.dart View 6 chunks +71 lines, -37 lines 0 comments Download
M pkg/analyzer/test/generated/incremental_resolver_test.dart View 10 chunks +38 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
6 years, 1 month ago (2014-11-20 17:29:50 UTC) #1
Brian Wilkerson
LGTM
6 years, 1 month ago (2014-11-20 17:41:19 UTC) #2
scheglov
6 years, 1 month ago (2014-11-20 17:56:58 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41857 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698