Handle named and optional arguments in cps-ir.

Handle named and optional arguments in cps-ir.

Refactor addArgumentsToList to makeArgumentsList.

R=floitsch@google.com, karlklose@google.com

Committed: https://code.google.com/p/dart/source/detail?r=41890

[sigurdm, 2014-11-20 09:27:17]

Patchset #1 (id:1) has been deleted

[sigurdm, 2014-11-20 09:29:11]

sigurdm@google.com changed reviewers:
+ karlklose@google.com

[floitsch, 2014-11-20 13:14:42]

floitsch@google.com changed reviewers:
+ floitsch@google.com

[floitsch, 2014-11-20 13:14:44]

LGTM.

https://codereview.chromium.org/742023002/diff/20001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_backend/codegen/codegen.dart (right):

https://codereview.chromium.org/742023002/diff/20001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_backend/codegen/codegen.dart:169:
compileConstant(ParameterElement parameter) {
Add return type.

https://codereview.chromium.org/742023002/diff/20001/pkg/compiler/lib/src/ssa...
File pkg/compiler/lib/src/ssa/builder.dart (right):

https://codereview.chromium.org/742023002/diff/20001/pkg/compiler/lib/src/ssa...
pkg/compiler/lib/src/ssa/builder.dart:4261: // calling
[addStaticSendArgumentsToList].
adapt comment.

https://codereview.chromium.org/742023002/diff/20001/pkg/compiler/lib/src/ssa...
pkg/compiler/lib/src/ssa/builder.dart:4451: // calling
[addStaticSendArgumentsToList].
ditto.

https://codereview.chromium.org/742023002/diff/20001/pkg/compiler/lib/src/uni...
File pkg/compiler/lib/src/universe/universe.dart (right):

https://codereview.chromium.org/742023002/diff/20001/pkg/compiler/lib/src/uni...
pkg/compiler/lib/src/universe/universe.dart:506: * Precondition:
`this.applies(element, world)`.
can you assert this?

https://codereview.chromium.org/742023002/diff/20001/pkg/compiler/lib/src/uni...
pkg/compiler/lib/src/universe/universe.dart:556: /// representation of
arguments.
Reverse the order.
The Ssa-one is the one that will go away. Make this one the one that has the
comment and the good name.

[sigurdm, 2014-11-21 09:52:53]

Ptal

https://codereview.chromium.org/742023002/diff/20001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_backend/codegen/codegen.dart (right):

https://codereview.chromium.org/742023002/diff/20001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_backend/codegen/codegen.dart:169:
compileConstant(ParameterElement parameter) {
On 2014/11/20 13:14:43, floitsch wrote:
> Add return type.

Done.

https://codereview.chromium.org/742023002/diff/20001/pkg/compiler/lib/src/ssa...
File pkg/compiler/lib/src/ssa/builder.dart (right):

https://codereview.chromium.org/742023002/diff/20001/pkg/compiler/lib/src/ssa...
pkg/compiler/lib/src/ssa/builder.dart:4261: // calling
[addStaticSendArgumentsToList].
On 2014/11/20 13:14:43, floitsch wrote:
> adapt comment.

Done.

https://codereview.chromium.org/742023002/diff/20001/pkg/compiler/lib/src/ssa...
pkg/compiler/lib/src/ssa/builder.dart:4451: // calling
[addStaticSendArgumentsToList].
On 2014/11/20 13:14:43, floitsch wrote:
> ditto.

Done.

https://codereview.chromium.org/742023002/diff/20001/pkg/compiler/lib/src/uni...
File pkg/compiler/lib/src/universe/universe.dart (right):

https://codereview.chromium.org/742023002/diff/20001/pkg/compiler/lib/src/uni...
pkg/compiler/lib/src/universe/universe.dart:506: * Precondition:
`this.applies(element, world)`.
On 2014/11/20 13:14:43, floitsch wrote:
> can you assert this?

Not without requiring the world as a parameter.

https://codereview.chromium.org/742023002/diff/20001/pkg/compiler/lib/src/uni...
pkg/compiler/lib/src/universe/universe.dart:556: /// representation of
arguments.
On 2014/11/20 13:14:43, floitsch wrote:
> Reverse the order.
> The Ssa-one is the one that will go away. Make this one the one that has the
> comment and the good name.

Done.

[karlklose, 2014-11-21 10:03:20]

LGTM.

https://codereview.chromium.org/742023002/diff/60001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_backend/codegen/task.dart (right):

https://codereview.chromium.org/742023002/diff/60001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_backend/codegen/task.dart:190: new CodeGenerator(glue,
work.registry);
Does it fit on one line now?

[sigurdm, 2014-11-21 10:09:10]

https://codereview.chromium.org/742023002/diff/60001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_backend/codegen/task.dart (right):

https://codereview.chromium.org/742023002/diff/60001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_backend/codegen/task.dart:190: new CodeGenerator(glue,
work.registry);
On 2014/11/21 10:03:20, karlklose wrote:
> Does it fit on one line now?

Yes

[sigurdm, 2014-11-21 10:09:42]

Committed patchset #4 (id:80001) manually as 41890 (presubmit successful).