Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issue 742013003: Code clean-up (Closed)

Created:
6 years, 1 month ago by Brian Wilkerson
Modified:
6 years, 1 month ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Code clean-up, add utility class for incremental scanning, add tests R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=41855

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+680 lines, -739 lines) Patch
M pkg/analyzer/lib/src/generated/scanner.dart View 48 chunks +448 lines, -616 lines 0 comments Download
M pkg/analyzer/test/enum_test.dart View 3 chunks +0 lines, -18 lines 0 comments Download
M pkg/analyzer/test/generated/scanner_test.dart View 22 chunks +232 lines, -105 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Brian Wilkerson
6 years, 1 month ago (2014-11-20 16:58:26 UTC) #2
scheglov
LGTM
6 years, 1 month ago (2014-11-20 17:02:40 UTC) #3
Brian Wilkerson
6 years, 1 month ago (2014-11-20 17:03:49 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41855 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698