Issue 741833003: dart2js: Add "onlyForRti" to Classes in model of the new emitter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 741833003: dart2js: Add "onlyForRti" to Classes in model of the new emitter. (Closed)

Created:
6 years ago by floitsch

Modified:
6 years ago

Reviewers:
karlklose, sigurdm

CC:
reviews_dartlang.org, karlklose

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

dart2js: Add "onlyForRti" to Classes in model of the new emitter. R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=41956

Patch Set 1 #

Total comments: 1

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -2 lines)			Patch
	M	pkg/compiler/lib/src/js_emitter/model.dart	View		1 chunk	+4 lines, -1 line	0 comments	Download
	M	pkg/compiler/lib/src/js_emitter/program_builder.dart	View		1 chunk	+4 lines, -1 line	1 comment	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

floitsch

Committed patchset #1 (id:1) manually as 41956 (presubmit successful).

6 years ago (2014-11-25 14:49:55 UTC) #5

sigurdm

6 years ago (2014-11-25 15:01:43 UTC) #6

Message was sent while issue was closed.

lgtm

https://codereview.chromium.org/741833003/diff/1/pkg/compiler/lib/src/js_emit...
File pkg/compiler/lib/src/js_emitter/program_builder.dart (right):

https://codereview.chromium.org/741833003/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/program_builder.dart:268:
_task.typeTestEmitter.rtiNeededClasses.contains(element);
Add a comment on `rtiNeededClasses` that it is the classes "only" needed for
rti. Or rename it to `classesOnleNeededForRti` or similar.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages